This repository has been archived by the owner on Jun 7, 2023. It is now read-only.
CE-868 Add support for modules shared from dev.wikia.com #4550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if ( !$title || $title->getNamespace() != NS_MODULE ) { | ||
| return array(); | ||
| } | ||
| $module = $this->fetchModuleFromParser( $title, SHARED_MODULES_PREFIX ); |
There was a problem hiding this comment.
Why are you passing the prefix to this call?
Grunny
changed the title
|
@Grunny @adamkarminski how about finally merging or closing it? |
Grunny
added a commit
that referenced
this pull request
Jun 23, 2015
CE-868 Add support for modules shared from dev.wikia.com
mszabo-wikia
added a commit
to Wikia/mediawiki-extensions-Scribunto
that referenced
this pull request
Apr 21, 2020
Add support for global Lua modules in UCP Scribunto, as done before for app in Wikia/app#4550. Unfortunately Scribunto doesn't offer an extension point here, so the relevant functionality has to be inlined. The actual business logic of fetching the content of global modules is handled by the UCP GlobalLuaModules extension.
t-tomalak
pushed a commit
to Wikia/mediawiki-extensions-Scribunto
that referenced
this pull request
Feb 22, 2022
Add support for global Lua modules in UCP Scribunto, as done before for app in Wikia/app#4550. Unfortunately Scribunto doesn't offer an extension point here, so the relevant functionality has to be inlined. The actual business logic of fetching the content of global modules is handled by the UCP GlobalLuaModules extension.
adaball
pushed a commit
to Wikia/mediawiki-extensions-Scribunto
that referenced
this pull request
Jan 31, 2023
Add support for global Lua modules in UCP Scribunto, as done before for app in Wikia/app#4550. Unfortunately Scribunto doesn't offer an extension point here, so the relevant functionality has to be inlined. The actual business logic of fetching the content of global modules is handled by the UCP GlobalLuaModules extension.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The solution bases on a "Dev:" prefix which works in require("Dev:ExampleModule"). The prefix is also used as a key for modules array that Lua loaders use. This prevents a name conflict since local modules are always in the NS_MODULE namespace and have "Module:" prefix.